Update Action View and Action Dispatch to use HTML5 when available #48523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilleiguaran
approved these changes
Jun 20, 2023
flavorjones
deleted the
flavorjones-update-action-view-and-action-dispatch-to-html5
branch
joelhawksley
added a commit
to ViewComponent/view_component
that referenced
this pull request
Jun 23, 2023
This change fixes a test in our suite broken by rails/rails#48523. Before the upstream change, invalid the invalid HTML5 in this test case was parsed without issue. The upstream change switched the Nokogiri parsing mode to HTML5, leading to parsing issues with our test case. I've converted all of the DOM nodes in this case into divs, preserving the intention of the test case but making it valid HTML5.
joelhawksley
added a commit
to ViewComponent/view_component
that referenced
this pull request
Jun 23, 2023
This change fixes a test in our suite broken by rails/rails#48523. Before the upstream change, invalid the invalid HTML5 in this test case was parsed without issue. The upstream change switched the Nokogiri parsing mode to HTML5, leading to parsing issues with our test case. I've converted all of the DOM nodes in this case into divs, preserving the intention of the test case but making it valid HTML5.
4 tasks
flavorjones
added a commit
to flavorjones/rails
that referenced
this pull request
Jul 4, 2023
Rails 7.1 defaults to Rails::HTML::Sanitizer.best_supported_vendor, earlier configs will use Rails::HTML4::Sanitizer. Related to rails#48523 / 55bca6b.
This was referenced Jul 6, 2023
flavorjones
added a commit
to flavorjones/rails
that referenced
this pull request
Aug 3, 2023
Use the helpers introduced in rails-dom-testing 2.2.0 instead of managing the HTML parsers as was done in rails#48523. See also related rails#47144 / ad79ed0
paulreece
pushed a commit
to paulreece/rails-paulreece
that referenced
this pull request
Aug 26, 2023
Use the helpers introduced in rails-dom-testing 2.2.0 instead of managing the HTML parsers as was done in rails#48523. See also related rails#47144 / ad79ed0
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
This change fixes a test in our suite broken by rails/rails#48523. Before the upstream change, invalid the invalid HTML5 in this test case was parsed without issue. The upstream change switched the Nokogiri parsing mode to HTML5, leading to parsing issues with our test case. I've converted all of the DOM nodes in this case into divs, preserving the intention of the test case but making it valid HTML5.
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
This change fixes a test in our suite broken by rails/rails#48523. Before the upstream change, invalid the invalid HTML5 in this test case was parsed without issue. The upstream change switched the Nokogiri parsing mode to HTML5, leading to parsing issues with our test case. I've converted all of the DOM nodes in this case into divs, preserving the intention of the test case but making it valid HTML5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Update Action Dispatch Assertions'
html_documentto use the HTML5 parser if it's available, to better represent what an end user will see in their browser DOM.Update Action View TestCase's private
document_root_elementand the form tag helper test to use HTML5 as well.Additional information
This is part of ongoing work to update Rails to use HTML5.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]